Skip to content

Semantic Text Index Options Integration Tests#130453

Merged
Mikep86 merged 8 commits intoelastic:mainfrom
Mikep86:semantic-text_index-options_license-tests
Jul 3, 2025
Merged

Semantic Text Index Options Integration Tests#130453
Mikep86 merged 8 commits intoelastic:mainfrom
Mikep86:semantic-text_index-options_license-tests

Conversation

@Mikep86
Copy link
Copy Markdown
Contributor

@Mikep86 Mikep86 commented Jul 2, 2025 •
edited
Loading

Adds integration tests for the semantic text index_options. They test how index_options validation and resolution is handled when using a basic license, which is important for a couple reasons:

  • It ensures that users using a basic license will not encounter issues related to index_options
  • It helps prevent potentially impactful regressions related to the license level

@Mikep86 Mikep86 requested review from jimczi and kderusso July 2, 2025 12:59
@Mikep86 Mikep86 added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.2.0 v9.1.1 v8.19.1 labels Jul 2, 2025
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) Team:Search - Relevance The Search organization Search Relevance team labels Jul 2, 2025
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 2, 2025

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 2, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)

@Mikep86
Copy link
Copy Markdown
Contributor Author

Mikep86 commented Jul 2, 2025

@elasticmachine update branch

@Mikep86
Copy link
Copy Markdown
Contributor Author

Mikep86 commented Jul 2, 2025

@elasticmachine update branch

Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Well structured integration tests to validate index_options behavior under basic license.

Comment thread ...usterTest/java/org/elasticsearch/xpack/inference/integration/SemanticTextIndexOptionsIT.java
kderusso
kderusso approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work and great example of license modification! I left one non-blocking nitpick as this is test code. Otherwise looks great to me!

Comment thread ...usterTest/java/org/elasticsearch/xpack/inference/integration/SemanticTextIndexOptionsIT.java
kderusso
kderusso approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Mikep86
Copy link
Copy Markdown
Contributor Author

Mikep86 commented Jul 3, 2025

@elasticmachine update branch

@Mikep86 Mikep86 merged commit 9b6913c into elastic:main Jul 3, 2025
32 checks passed
@Mikep86 Mikep86 mentioned this pull request Jul 3, 2025
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Jul 3, 2025
@Mikep86
Semantic Text Index Options Integration Tests (elastic#130453)
cef8029
@Mikep86 Mikep86 mentioned this pull request Jul 3, 2025
Merged
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

elasticsearchmachine commented Jul 3, 2025

💚 Backport successful

Status Branch Result
✅ 9.1
✅ 8.19

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Jul 3, 2025
@Mikep86
Semantic Text Index Options Integration Tests (elastic#130453)
c19ed0f
elasticsearchmachine pushed a commit that referenced this pull request Jul 3, 2025
@Mikep86
[9.1] Semantic Text Index Options Integration Tests (#130453) (#130581)
a1af0bc 
* Semantic Text Index Options Integration Tests (#130453)

* Remove default BBQ index options test
elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2025
@Mikep86
[8.19] Semantic Text Index Options Integration Tests (#130453) (#130582)
8f80eab 
* Semantic Text Index Options Integration Tests (#130453)

* Remove default BBQ index options test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso approved these changes

@jimczi jimczi Awaiting requested review from jimczi

+1 more reviewer

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) >test Issues or PRs that are addressing/adding tests v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mikep86 @elasticsearchmachine @kderusso @Samiul-TheSoccerFan @elasticmachine